[Click] Radiotap Decap

[Ian Rose]

Hi Amita -

I think you might be using an old source?  The current version that I 
see in Git has the following line 163 which I think is the one you are 
talking about:

>  p->pull(le16_to_cpu(th->it_len));

which I think should work right.  I know that fairly recently it was 
just doing p->pull(th->it_len) because I ran into a similar problem as 
you, but the above works for me and hopefully will for you too.

- Ian


Amita Ekbote wrote:
> Hey,
> 
> I have been using click on openwrt machines since a very long time ; I
> noticed the following "bug" in the radiotap element
> 
> If you do something like FromDevice(ath0) -> RadiotapDecap -> Print ->
> Discard , I see the prints printing out just 0.
> 
> Now the radiotap decap does a pull of the radiotaphdr->len and it looks like
> it pulls a lot more than its supposed to. It is a byte ordering problem but
> somehow even ntohs doesnt seem to have any effect. I replaced the pull (
> length ) with pull (sizeof(header)) .
> 
> Can someone else check this on any other device ? Also I am still surprised
> that ntohs doesnt seem to work, is there something I am missing? I tested
> the values by printing them out.
> 
> Thanks,
> 
>