[Click] Linux 2.6.24.7 patch in

[Eddie Kohler]

Hi Kevin, thanks very much for checking this out!

springbo at cs.wisc.edu wrote:
> Thanks Eddie!
> 
> I've run into a couple complications:
> 1) It looks like there is a logic error in Packet::has_network_header().
> I've attached a patch.

Yep, oops.  has_transport_header() was also wrong; both are fixed.

> 2) click-uninstall'ing the kernel module results in a general protection
> fault. My configure string is  "./configure --enable-multithread
> --enable-user-multithread --enable-adaptive --enable-intel-cpu CFLAGS=-g
> CXXFLAGS=-g". I am building on an x86_64 machine. The click configuration
> used or the number of threads doesn't seem to affect the problem. See
> gpf.log for more information.

This is a little worrisome.  I wonder if the problem here was related to

http://read.cs.ucla.edu/gitweb?p=click;a=commit;h=f72c997281d970ef6fc1cf94feefc23125c31e20

Do you have a version of proclikefs.c as created by the prior patch?  If so, 
does unloading work with that proclikefs?

> 3) I'm getting warnings when click descends into the kernel source
> directory to build the module. See warning.log. My guess is that this is
> due to the improved linuxmodule build process.

I reenabled the relevant part of Joonwoo's patch.

> Polling seems to be working with the e1000-7.6.15.5 driver.

Cool!

Eddie


> Thanks again,
> Kevin Springborn
> 
> 
> 
> 
>> Hi all,
>>
>> Click has been updated with the patch for Linux 2.6.24.7 support; and the
>> Linux 2.6.24.7 patch has been checked into the Click repository.  Please
>> let
>> us know if all of this works.  I would love to hear working or not working
>> reports from users.
>>
>> Thanks very much to, especially, Adam Greenhalgh, Joonwoo Park, and Nemean
>> Networks for putting together this patch.
>>
>> Thanks,
>> Eddie
>> _______________________________________________
>> click mailing list
>> click at amsterdam.lcs.mit.edu
>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>>