[Click] memory leak patch for click (on linux)

[JasonPark]

Hi guys

There is a memory leakage on linuxmodule sched.cc

 

When I rmmod click, I got 5 still allocated ptr.

click error: 5 outstanding news

 

I made & applied memory profiler stuff and found that 5 EIPs that called
new.

 

FUNC : _ZN6MasterC1Ei+0xf7/0x150 [click]

FUNC : _ZN6MasterC1Ei+0xf7/0x150 [click]

FUNC : _ZN6VectorIPvE7reserveEi+0x3c/0xb0 [click]

FUNC : _ZN6MasterC1Ei+0xf7/0x150 [click]

FUNC : _Z16click_init_schedP12ErrorHandler+0x3a/0x460 [click]

 

Here is patch for fix leakage.

------------------------------CUT HERE ----------------------------

$ cvs diff sched.cc

Index: sched.cc

===================================================================

RCS file: /cvs/click/release/one/linuxmodule/sched.cc,v

retrieving revision 1.53

diff -r1.53 sched.cc

413a414,419

> 

>       delete click_master;

>       click_master = NULL;

> 

417a424,429

> 

>       delete click_master;

>       click_master = NULL;

>------------------------------CUT HERE ----------------------------

 

Jason Park

www.geninetworks.com

 

 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 5818 bytes
Desc: not available
Url : https://amsterdam.lcs.mit.edu/pipermail/click/attachments/20051027/c7af88c7/winmail.bin