[Click] Plans to merge pending pull requests?

[Avinash Sridharan]

Thanks a lot for the info Eddie.
This is really helpful. I guess I just started the patch process assuming
that click would not work with the kernel without the patch. I will try
compiling it with the newer kernel, and load it as a module and see what
happens.

Meanwhile will work on trying to get the patch working with 3.4. I noticed
that most of the click patch deals with plugging into the netif_receive_skb
and skb_recycle. I will "try" to get this working with a newer kernel.

regards,
Avinash

On Wed, Jan 16, 2013 at 11:26 AM, Eddie Kohler <ekohler at gmail.com> wrote:

> Hi Avinash,
>
> At this point you don't need a Linux patch to compile or run Click. I
> recommend you attempt to do without it. Click hacks its way into the Linux
> packet processing chain, and that hack may not work on all kernels. But try
> it and let us know what you see.
>
> So why still have the patch at all? Because the patch supports polling. I
> would love a later patch that supports polling!
>
> Eddie
>
>
>
> On 1/16/13 2:04 PM, Avinash Sridharan wrote:
>
>> Hi Eddie,
>>   On a related note. Are there click patches available for linux kernels
>>  > 3.0 ? I was hoping to run click in kernel mode under UML (user-mode
>> linux) for better debuggability and understanding. On a system running
>> kernel 3.1.0 and higher I was unable to get UML running with an older
>> linux kernel < 2.6.38, to apply any of the existing click kernel patches
>> for the older linux kernel. On the UML thread I was informed that UML
>> compiled for older linux kernels but doesn't play well with new version
>> of gcc (it just crashes on bootup).
>>
>> So, I figured the cleaner solution would be to get a patch for linux
>> kernel > 3.0 for click. I couldn't find this when I pulled the git
>> repository for click. Is this something that is already available?
>> Meanwhile I have started applying the older patches to a 3.4 linux
>> kernel and resolving the conflicts. I am relatively comfortable with
>> kernel development, but wouldn't call myself an expert at this point. So
>> wanted some pointers in resolving this issue and hints on proceeding
>> further.
>>
>> Thanks,
>> Avinash
>>
>>
>>
>> On Wed, Jan 16, 2013 at 10:05 AM, Eddie Kohler <ekohler at gmail.com
>> <mailto:ekohler at gmail.com>> wrote:
>>
>>     Hi Jimmy,
>>
>>     Thanks for the reminder. I went ahead and merged your pull request, as
>>     well as versions of all the other outstanding pull requests. I also
>>     updated the patchless installation procedure and some problematic
>>     aspects of the Click filesystem. At this point Click can install
>> simple
>>     configurations into patchless Ubuntu 8.04 (2.6.24), 10.04 (2.6.32),
>>     12.04 (3.2), and 12.10 (3.5) kernels. I have not verified that Click
>> can
>>     send and receive packets in all these configurations, but it is a
>> start.
>>     Please open issues and other pull requests as you find them.
>>
>>     Best,
>>     Eddie
>>
>>
>>     On 12/19/12 11:04 AM, Jimmy Kjällman wrote:
>>      > Eddie, other maintainers of Click,
>>      >
>>      > there's a number of pending pull requests in GitHub. Do you have
>>     any plans to merge them into the master branch, or to give comments
>>     about them?
>>      >
>>      > At least some of the locking-related issues are quite critical.
>>     I.e., in many new Linux kernels the Click module causes crashes and
>>     deadlocks very frequently without the corresponding fixes. Or, to
>>     put in another way, the module is not that useful without these
>>     fixes in its current state. Therefore it would be nice if they were
>>     included into Click.
>>      >
>>      > BR,
>>      >
>>      > Jimmy Kjällman
>>      >
>>      >
>>      > ______________________________**_________________
>>      > click mailing list
>>      > click at amsterdam.lcs.mit.edu <mailto:click at amsterdam.lcs.**mit.edu<click at amsterdam.lcs.mit.edu>
>> >
>>
>>      > https://amsterdam.lcs.mit.edu/**mailman/listinfo/click<https://amsterdam.lcs.mit.edu/mailman/listinfo/click>
>>      >
>>     ______________________________**_________________
>>     click mailing list
>>     click at amsterdam.lcs.mit.edu <mailto:click at amsterdam.lcs.**mit.edu<click at amsterdam.lcs.mit.edu>
>> >
>>     https://amsterdam.lcs.mit.edu/**mailman/listinfo/click<https://amsterdam.lcs.mit.edu/mailman/listinfo/click>
>>
>>
>>