[Click] suggested patch for DelayUnqueue

[Eddie Kohler]

Hi Ian,

Thanks for this long-ago patch.

I actually am not sure that I like it.  It slightly slows down comparisons 
(trivially, but still), and it makes DelayUnqueue unlike (say) LinkUnqueue, 
and it's the sort of configuration knob that confuses me -- either it should 
always update or never update, I'd say.

I applied some parts of the patch -- namely, not updating the timestamp to THE 
CURRENT time but rather updating it to the delayed time; and writable "delay" 
handler.  Do you really need "UPDATE false" behavior?  Could you cope with, e.g.,

DelayUnqueue(0.1) -> AdjustTimestamp(-0.1) -> ...

?  (Just added AdjustTimestmap.)


Eddie




On 05/06/2010 10:22 AM, Ian Rose wrote:
> Hi -
>
> I've noticed that DelayUnqueue always updates the timestamp of output packets
> to the current time. The enclosed patch adds an optional UPDATE configuration
> parameter (default=true) that can turn off this behavior.
>
> cheers,
> - Ian
>
>
>
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click