[Click] [PATCH 1/2] click-uninstall: Unmount proclikefs before unloading linuxmodule

[Joonwoo Park]

Hi Eddie,

Exactly,  I encountered click-uninstall bug while working for the 2.6.24 patch.
I thought that this click-uninstall problem was occuring just with
2.6.24 and I didn't suspect Click's problem.
With your patch, it seems to be fixed.  I cannot see any problem now.
Thank you.

Kevin, does click-uninstall work without my patch?

Thanks,
Joonwoo

2008/9/10 Eddie Kohler <kohler at cs.ucla.edu>:
> Hi Joonwoo,
>
> The current order is correct.  Proclikefs is designed to allow Click to
> unload even while other programs have files in /click open.  I imagine that
> you were trying to solve the click-uninstall bug with this patch, but after
> I checked in my patch that made RouterThread::_lock a recursive Spinlock
> (rather than a non-recursive spinlock_t), I can click-uninstall with no
> problems.  Does this make sense?
>
> Eddie
>
>
> Joonwoo Park wrote:
>>
>> Hello Eddie,
>>
>> I found that click-uninstall is unloading linuxmodule before
>> unmounting procklikefs.
>> This patch fix it to unmount proclikefs before unloading liuxmodule as
>> like click-uninstall for badmodule.
>>
>> Please consider applying this patch.
>>
>> Thanks,
>> Joonwoo
>
>