[Click] [PATCH 1/2] click-uninstall: Unmount proclikefs before unloading linuxmodule

Eddie Kohler kohler at cs.ucla.edu
Wed Sep 10 11:58:45 EDT 2008


Hi Joonwoo,

The current order is correct.  Proclikefs is designed to allow Click to unload 
even while other programs have files in /click open.  I imagine that you were 
trying to solve the click-uninstall bug with this patch, but after I checked 
in my patch that made RouterThread::_lock a recursive Spinlock (rather than a 
non-recursive spinlock_t), I can click-uninstall with no problems.  Does this 
make sense?

Eddie


Joonwoo Park wrote:
> Hello Eddie,
> 
> I found that click-uninstall is unloading linuxmodule before
> unmounting procklikefs.
> This patch fix it to unmount proclikefs before unloading liuxmodule as
> like click-uninstall for badmodule.
> 
> Please consider applying this patch.
> 
> Thanks,
> Joonwoo



More information about the click mailing list