[Click] e100 polling, no packets transmitted, patches broke

[Paine, Thomas Asa]

        In October of 2007, we had worked out some issues where the tx queue was never woken when polling and I would see all TX stop.  At the time I was seeing this behavior when there would be a link state change on a nic. (https://pdos.csail.mit.edu/pipermail/click/2007-October/thread.html#6435)

        In looking back through the mailing list archive, I see Joonwoo was looking at, and working on, NAPI a month later (https://pdos.csail.mit.edu/pipermail/click/2007-November/thread.html#6531) and (https://pdos.csail.mit.edu/pipermail/click/2007-November/006537.html), of which those patches will no longer work on the current source.

        In trying the latest git of Click, I'm seeing similar behavior I had in October, but worse.  This time, I'm not able to transmit at all when in polling mode.  I added some additional output from the linuxmodule's todevice.cc and below is what I'm seeing when I start click.  To test this, I was just using the udpgen example (@ 1pps), so I won't post that.  If polling is not enabled, things seem to run fine.  Likewise, todevice and other files have changed since October, so the patches from October are likely out as well.

        So I'm curious what I should be looking at doing.  Should I still be looking at polling, should I be changing something to use NAPI, are there open issues?  Does the current source tree incorporate any of the works related to polling/NAPI work from back in October and/or November?  Should they?  How can we get these types of changes checked in to prevent this?

e1000: eth1: e1000_watchdog_1: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
e1000: eth2: e1000_watchdog_1: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
e1000: eth5: e1000_watchdog_1: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
click: starting router thread pid 1028 (c1a312c0)
e1000_poll_on
ToDevice eth1 is in polling mode, calling _dev->tx_queue()
ToDevice interface eth1 tx_queue retruned 0
e1000: eth1: e1000_watchdog_1: NIC Link is Down
ToDevice interface eth1 tx_queue retruned -1
ToDevice eth1 rejected a packet!


No TX packets!

# /sbin/ifconfig eth1
eth1      Link encap:Ethernet  HWaddr 00:60:E0:E0:9A:2C
          UP BROADCAST PROMISC MULTICAST  MTU:1500  Metric:1
          RX packets:48 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:3072 (3.0 KiB)  TX bytes:0 (0.0 B)
          Base address:0xb700 Memory:f8000000-f8020000

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
   Thomas Paine {paineta at uwec.edu}
   University of Wisconsin - Eau Claire
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~