[Click] Linuxmodule compile error

Eddie Kohler kohler at cs.ucla.edu
Thu Jun 19 11:15:23 EDT 2008


Thanks for the fix -- it's checked in!

Eddie


springbo at cs.wisc.edu wrote:
> Hi,
> 
> It seems that the 'Handler: Add READ_PRIVATE and WRITE_PRIVATE flags.'
> commit accidentally removed the definition of exclusive() from handler.hh.
> I needed to add it back in, in order to get the linuxmodule to compile for
> me (it is used in clickfs.cc).
> 
> 
> My fix:
> --- click.source/include/click/handler.hh       2008-06-19
> 08:44:05.000000000 -0500
> +++ click/include/click/handler.hh      2008-06-19 09:51:21.000000000 -0500
> @@ -123,7 +123,9 @@
>       * processing.  In the Linux kernel module driver, reading or writing an
>       * exclusive handler using the Click filesystem will first lock all
> router
>       * threads and handlers.  Exclusivity is set by the EXCLUSIVE flag.  */
> -    inline bool exclusive() const;
> +    inline bool exclusive() const {
> +      return _flags & EXCLUSIVE;
> +    }
> 
>      /** @brief Check if quotes should be removed when calling this handler.
>       *
> 
> 
> Thanks,
> Kevin Springborn
> 
> 
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click


More information about the click mailing list