[Click] patches for 2.6.23.12

Joonwoo Park joonwpark81 at gmail.com
Mon Jan 28 03:32:25 EST 2008


> On 26/01/2008, Giovanni Di Stasi <gdistasi at gmail.com> wrote:
> > Il Sunday 06 January 2008 19:28:41 Adam Greenhalgh ha scritto:
> > > Folks,
> > >
> > > I have versions of click and the latest 2.6.23.12 kernel
> > > that compile and run click but my tests are failing on setting
> > > promiscous mode and assinging click threads to cpus in the static
> > > thread scheduler. If anyone would like patches let me know other wise I'll
> > > potter on at it in spare time. Bewarned a bunch of stuff has changed,
> > > skbuff, netdev, and possibly some of the cpu core assignment stuff.
> > > Stuff needs changing in both click
> > > and in linux.
> >

Hellow Adam,

Thanks for your hard work.
I have tested your patch against 2.6.23.12.

But It seems that it is for 2.6.23.13.
--- clean/linux-2.6.23.13/Makefile	2008-01-09 17:18:17.000000000 +0000
+++ linux-2.6.23.12/Makefile	2007-12-23 07:41:04.000000000 +0000
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 23
-EXTRAVERSION = .13
+EXTRAVERSION = .12
 NAME = Arr Matey! A Hairy Bilge Rat!

Anyway, It was pretty hard to build kernel with my .config.
But I couldn't find any problem to running click with your patch.
Can you please introduce me to how to reproduce the problem?

For me, it seems to work both of setting static thread scheduler 
and promiscous mode.
But actually recent linux had made a new way of setting promiscous mode
(the dev_set_rx_mode & dev_unicast_add does)

On Sat, Jan 26, 2008 at 09:31:56AM +0000, Adam Greenhalgh wrote:
> again. Yesterday 2.6.24 was release which i think is probably a better
> kernel to target than 2.6.23.12.
> 

fyi, the 2.6.24 linux-net had improved, including big napi bug fix.
(http://thread.gmane.org/gmane.linux.kernel/612328/focus=80407)
Also, I suppose that it holds at least a regression to be fixed for
the net, since It's my bad. :(
(http://thread.gmane.org/gmane.linux.network/84420/focus=84442)

Thanks,
Joonwoo


More information about the click mailing list