[Click] [PATCH] patches for linux 2.6.24

Joonwoo Park joonwpark81 at gmail.com
Mon Feb 11 20:42:41 EST 2008


On Mon, Feb 11, 2008 at 05:10:18PM -0000, Egi, Norbert wrote:
> >I guess the assertion issue  is releated locking problem, I sent a patch for it.
> >Since I'm off for this week, I can't test your patch at this moment.
> >I'll dig these things at next week and I'll try NAPI as a possible
> >option for e1000 that you patched.
> 
> Joonwoo,
>  
> Yes, it was related to a locking problem when I wanted to have the interfaces in promiscuous mode. It looks so that the dev_set_promiscuity function (in net/core/dev.c) requires the calling thread to hold rtnl mutex by calling rtnl_lock(), so I added this to anydevice.cc with the corresponding rtnl_unlock(). This eliminated the assertion problem I had. So far I haven't experienced any other problems with the patches yet. (By the way, I didn't get the patch you mentioned above.)
>  
> Cheers,
> Norbert

Thanks Norbert,
Now, when I think of it, I feel your patch might work for Adam's problem
about promiscuous mode.
I'm struggling to get a time for the work that I mentioned.
I'll try it ASAP and I'll let you know from this list.

Thanks,
Joonwoo


More information about the click mailing list