[Click] [PATCH] patches for linux 2.6.24

Egi, Norbert n.egi at lancaster.ac.uk
Mon Feb 11 12:10:18 EST 2008


>I guess the assertion issue  is releated locking problem, I sent a patch for it.
>Since I'm off for this week, I can't test your patch at this moment.
>I'll dig these things at next week and I'll try NAPI as a possible
>option for e1000 that you patched.

Joonwoo,
 
Yes, it was related to a locking problem when I wanted to have the interfaces in promiscuous mode. It looks so that the dev_set_promiscuity function (in net/core/dev.c) requires the calling thread to hold rtnl mutex by calling rtnl_lock(), so I added this to anydevice.cc with the corresponding rtnl_unlock(). This eliminated the assertion problem I had. So far I haven't experienced any other problems with the patches yet. (By the way, I didn't get the patch you mentioned above.)
 
Cheers,
Norbert
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: click-1.6.0-linux-2.6.24-2.patch
Url: https://pdos.csail.mit.edu/pipermail/click/attachments/20080211/069a5f48/attachment-0001.txt 


More information about the click mailing list