[Click] Grid code and SMALL_GRID_HEADERS

[Manuel Requena]

Maybe some errors are due to changes in the compiler. But, it is not the case for others. An
example, when compiling pingpong.cc:

  CXX ../elements/grid/pingpong.cc
../elements/grid/pingpong.cc: In member function ‘virtual Packet* PingPong::simple_action(Packet*)’:
../elements/grid/pingpong.cc:77: error: ‘stat_t’ is not a member of ‘LinkStat’
../elements/grid/pingpong.cc:77: error: ‘s’ was not declared in this scope
../elements/grid/pingpong.cc:77: error: ‘class LinkStat’ has no member named ‘_stats’
../elements/grid/pingpong.cc:96: error: ‘class LinkStat’ has no member named ‘get_bcast_stats’

But no trace about get_bcast_stats in LinkStat class.
get_bcast_stats is used in pingpong.cc and gridroutetable.cc.

Looking into CVS, get_bcast_stats disappears from version 1.6 to 1.7
http://cvs.pdos.csail.mit.edu/cvs/click/release/one/elements/grid/linkstat.hh.diff?r1=1.6;r2=1.7;f=h

Patch is commented by decouto... you?!:
"Reworked design and implementation of LinkStat element for measuring broadcast loss rates"

Reworked but not finished yet... I guess. ;-)

If the code is only related with statistics, I can live without them by now, but this part of code
is broken.

Manuel


> -----Mensaje original-----
> De: decouto at gmail.com [mailto:decouto at gmail.com]En nombre de Douglas S.
> J. De Couto
> Enviado el: miércoles, 27 de junio de 2007 20:41
> Para: Manuel Requena
> CC: click at amsterdam.lcs.mit.edu; grid at amsterdam.lcs.mit.edu
> Asunto: Re: Grid code and SMALL_GRID_HEADERS
>
>
> Hmmm, I wonder who wrote that pithy yet informative comment...  Some
> smelly graduate student I suspect.
>
> The last time I used that code was in Spring 2004; at that time I
> recall that everything ran fine with and without SMALL_GRID_HDRS
> defined.  Perhaps it is a compiler issue (e.g. changes in the compiler
> since the last time someone tried to use the code without
> SMALL_GRID_HDRS), or perhaps someone has broken the code.  Have you
> looked at the change history for grid.hh or one of the files that
> isn't compiling?
>
> d
>
> On 6/27/07, Manuel Requena <manuel.requena at cttc.es> wrote:
> > Hello,
> >
> > I want to use elements from the Grid project. Specially, I'm trying to use the
> > LookupGeographicGridRoute element because I want to implement geographic forwarding.
> > When I use it, it says: "LookupGeographicGridRoute geo: received packet of type GRID_NBR_ENCAP
> > without good destination location".
> >
> > If I look into the code, I realize that I need to undefine SMALL_GRID_HEADERS in
> grid.hh file. But
> > things get worse. I get a lot of compilation errors everywhere in the grid code, that
> I'm trying to
> > fix but it is painful.
> >
> > In fact, grid.hh says:
> > "
> > //defining this will break lots of shit
> > #define SMALL_GRID_HEADERS
> > #define SMALL_GRID_PROBES
> > "
> >
> > Which is the state of SMALL_GRID_HEADERS-related code?
> > Anyone is using or has used grid elements (LookGeographicGridRoute,...) ?
> >
> > Best regards,
> > Manuel
> >
> >