[Click] #include <cstdarg> vs. #include <stdarg.h>

[Douglas S. J. De Couto]

well, for C++ code it *is* the right thing to do.  because all those 
things should live under the std namespace.  the right thing to do (but 
a pain in the ass) is to change all standard library stuff to use std:: 
in front, or put `using std;' at the top of files.

although i know some people have strong feelings about namespaces...

d

On Wednesday, Aug 13, 2003, at 14:23 US/Eastern, Eddie Kohler wrote:

> Last October, I checked in this change to Click:
>
> 2002-10-05 Saturday 13:43  Eddie Kohler <kohler at icir.org>
>
> 	* config-userlevel.h.in (1.11), apps/csclient/csclient.cc (1.6),
> 	apps/csclient/csclient.hh (1.5), elements/analysis/anonipaddr.cc
> 	(1.9),  .................................................,
> 	tools/lib/toolutils.cc (1.46), userlevel/click.cc (1.70): use C++
> 	#include files when available (<cstdio> instead of <stdio.h>), in
> 	preparation for GCC 3.x
>
> It was wrong, wrong, wrong. The "C++" #include files, like <cstdio>, 
> put
> everything in 'namespace std'.
>
> So I'm going to revert that change. The question is, why did it get 
> put in
> in the first place?? I feel like someone said it was the right thing 
> to do,
> but can't remember who. Identify yourself, if you can! What will break 
> if
> we go back to <stdio.h>-style?
>
> Eddie
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>
--
Douglas S. J. De Couto     <decouto at lcs.mit.edu>