[Click] #include <cstdarg> vs. #include <stdarg.h>

Eddie Kohler kohler at icir.org
Wed Aug 13 12:23:46 EDT 2003


Last October, I checked in this change to Click:

2002-10-05 Saturday 13:43  Eddie Kohler <kohler at icir.org>

	* config-userlevel.h.in (1.11), apps/csclient/csclient.cc (1.6),
	apps/csclient/csclient.hh (1.5), elements/analysis/anonipaddr.cc
	(1.9),  .................................................,
	tools/lib/toolutils.cc (1.46), userlevel/click.cc (1.70): use C++
	#include files when available (<cstdio> instead of <stdio.h>), in
	preparation for GCC 3.x

It was wrong, wrong, wrong. The "C++" #include files, like <cstdio>, put
everything in 'namespace std'.

So I'm going to revert that change. The question is, why did it get put in
in the first place?? I feel like someone said it was the right thing to do,
but can't remember who. Identify yourself, if you can! What will break if
we go back to <stdio.h>-style?

Eddie


More information about the click mailing list