[chord] patch comments
Michael Walfish
mwalfish at lcs.mit.edu
Fri Jul 25 15:04:21 EDT 2003
| > void
| > +dhashclient::insert (bigint key, const char *buf,
| > + size_t buflen, cbinsertgw_t cb,
| > + ptr<option_block> options)
| > +{
| > + insert_worker_nopk (key, buf, buflen, cb, DHASH_CONTENTHASH, options);
| > +}
| > +
| > +void
| > dhashclient::insert (const char *buf, size_t buflen, cbinsertgw_t cb,
| > ptr<option_block> options)
| > {
| > @@ -128,6 +136,13 @@
| > insert (key, buf, buflen, cb, options);
| > }
| >
| > +void
| > +dhashclient::insert_noauth (bigint key, const char *buf,
| > + size_t buflen, cbinsertgw_t cb,
| > + ptr<option_block> options)
| > +{
| > + insert_worker_nopk (key, buf, buflen, cb, DHASH_NOAUTH, options);
| > +}
|
| I don't see the difference between the first insert above and this
| new insert_noauth method. I'll play with this a little.
the ctype is different.
you could stick with one insert() method but then you'd have to expose the
dhash_ctype to callers (which you might want to do for consistency with
retrieves).
More information about the chord
mailing list