[chord] patch comments

Emil Sit sit at MIT.EDU
Fri Jul 25 12:06:55 EDT 2003


I've committed a number of modified patches based on your suggestions.
Upon closer examination, I have the following comments...

> diff -ru chord-src-head/devel/test_types.C chord-src-noauth/devel/test_types.C
> --- chord-src-head/devel/test_types.C	2003-07-24 01:46:21.000000000 -0400
> +++ chord-src-noauth/devel/test_types.C	2003-07-25 04:34:56.000000000 -0400

I'm going to hold off on this one for a little while actually.
Perhaps we can make this a more useful test program and remove
the need for that magic2ctype stuff by streamlining the dhash_ctype
enum. (It seems like DHASH_DNSSEC can be punted and removed by
DHASH_NOAUTH.)

> diff -ru chord-src-head/dhash/dhashclient.C chord-src-noauth/dhash/dhashclient.C
> --- chord-src-head/dhash/dhashclient.C	2003-07-25 04:24:11.000000000 -0400
> +++ chord-src-noauth/dhash/dhashclient.C	2003-07-25 04:47:37.000000000 -0400
> @@ -121,6 +121,14 @@
>  }
>  
>  void
> +dhashclient::insert (bigint key, const char *buf,
> +                     size_t buflen, cbinsertgw_t cb, 
> +		     ptr<option_block> options)
> +{
> +  insert_worker_nopk (key, buf, buflen, cb, DHASH_CONTENTHASH, options);
> +}
> +
> +void
>  dhashclient::insert (const char *buf, size_t buflen, cbinsertgw_t cb,
>                       ptr<option_block> options)
>  {
> @@ -128,6 +136,13 @@
>    insert (key, buf, buflen, cb, options);
>  }
>  
> +void
> +dhashclient::insert_noauth (bigint key, const char *buf,
> +                            size_t buflen, cbinsertgw_t cb,
> +                            ptr<option_block> options)
> +{
> +    insert_worker_nopk (key, buf, buflen, cb, DHASH_NOAUTH, options);
> +}

I don't see the difference between the first insert above and this
new insert_noauth method.  I'll play with this a little. 

-- 
Emil Sit / MIT LCS PDOS / http://pdos.lcs.mit.edu/chord/  


More information about the chord mailing list