[Click] About my ipsec additions

[Eddie Kohler]

Hi Markku,

Thanks so much for producing this branch! Not only would any vaguely
working IPsec elements be better than what we have now, but also your
code looks quite strong, so I'm inclined to just merge it, with your
blessing.

But I looked through it very briefly for nits. Here are two,
interested in your thoughts.
- IPsec::Mutex: Why? We have Spinlock for this... At least make it a
nested class or call it IPsecMutex.
- dynamic_cast: What you actually want to do here is call "cast()", a
Click-specific function designed for exactly this use. So

IPsecTransform *tr = (IPsecTransform *)
e->output(port).element()->cast("IPsecTransform");

Best,
Eddie



On Fri, Jun 15, 2012 at 2:36 AM, Markku Savela <Markku.Savela at vtt.fi> wrote:
> On 06/14/2012 05:09 PM, Markku Savela wrote:
>> As the whole thing is just additions to mainline, it could also be
>> just merged into it?
>
> On second thought, need to hold on this. I forgot that due my use
> of "dynamic_cast" operator, the code fails to compile into kernel
> module. Thus, including it in mainline as is, would break kernel
> module build, if ipsec is included...
>
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click