[Click] AddressInfo on Click 2.0

[Eddie Kohler]

Hi Sascha,

Good catch!  You're right that the check was unnecessary.  I've applied a 
version of your patch, as well as another related fix.  Thanks very much.

Best,
Eddie


On 8/25/11 7:35 AM, Sascha Alexander Jopen wrote:
> Hey,
>
> does anybody use the AddressInfo element with click 2.0 and real device
> names, instead of supplying IP addresses directly?
>
> If i use AddressInfo(deviceName wlan0:ip wlan0:eth) for example, i get
> the following error: "wlan0:ip" is not a recognizable address.
>
> Either i use AddressInfo in a wrong way, or this is an error. If i use
> it wrong, maybe someone could tell me the right way?
>
> It seems, this error is caused by a check within the IPPrefixArg and
> IPAddressArg parsers, which check for a non-null ArgContext. When
> resolving the ip address of such an interface, there is no underlying
> click element, thus the context is null and the ip is never fetched from
> the interface. Removing this check seems to fix the problem, but i don't
> know, if this can lead to access violations later on. The check should
> be there for a good reason.
>
> The attached patch "fixes" this problem by simply removing those checks.
> Probably some more work has to be done to make this robust.
>
> Regards,
> Sascha Jopen
>
>
>
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click