[Click] add TCPFragmenter element
Beyers Cronje
bcronje at gmail.com
Thu Sep 30 07:08:13 EDT 2010
Hi Cliff,
A small comment from my side, it does not seem that the element takes ip
header options in consideration when gaining a pointer to the tcp header.
I would change:
const click_tcp *tcp = reinterpret_cast<const click_tcp *>(ip + 1);
To:
const click_tcp *tcp = p->tcp_header();
This ensures accurate offset to the tcp header even when ip options are
present.
Beyers
On Thu, Sep 30, 2010 at 2:29 AM, Cliff Frey <cliff at meraki.com> wrote:
> I am planning on adding this element to click. If anyone has any
> comments/feedback on it, let me know.
>
> Cliff
>
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>
>
More information about the click
mailing list