[Click] KernelFilter patch
Beyers Cronje
bcronje at gmail.com
Fri Oct 29 19:39:03 EDT 2010
Hi guys,
The patch below fixes a bug in KernelFilter::device_filter. As per access()
man page, on success (all requested permissions granted), zero is returned.
Beyers
!!!!!!!!!!!!!!!!!!!!!!!!!!!!
--- kernelfilter.cc.orig 2010-10-30 00:46:31.973642384 +0200
+++ kernelfilter.cc 2010-10-30 00:56:48.449641054 +0200
@@ -85,9 +85,9 @@
StringAccum cmda;
if (iptables_command)
cmda << iptables_command;
- else if (access("/sbin/iptables", X_OK))
+ else if (access("/sbin/iptables", X_OK) == 0)
cmda << "/sbin/iptables";
- else if (access("/usr/sbin/iptables", X_OK))
+ else if (access("/usr/sbin/iptables", X_OK) == 0)
cmda << "/usr/sbin/iptables";
else
return errh->error("no %<iptables%> executable found");
More information about the click
mailing list