[Click] ControlSocket uses reference to local variable

[Eddie Kohler]

Hi Bart,

I can see why this would concern but it's actually OK.  The _proxied_errh 
variable is only used locally, during the call to the handler.  This will be 
clearer if we reset _proxied_errh to 0, which I'll do.

E


Bart Braem wrote:
> Hello,
> 
> In proxy_error_function ControlSocket uses cs->proxied_errh . This  
> variable is assigned in parse_handler, read_command and llrcp_command  
> to a local variable and used later on, in a different function. That  
> can't be good, I guess some kind of a class field should be used?
> 
> Regards,
> Bart Braem