[Click] Fwd: [PATCH] IPv6 support

[Eddie Kohler]

Johan,

Thanks very much for the FromHost patch as well.  I can't apply this patch as 
is, however.

- You refer to conf[1], but this might not exist, or might be a keyword.  Need 
to use cp_va_kparse functions to extract DST as a string and then check it.

- _near6/_near should be in a union, same with _mask6/_mask.

- Why both isIPv4 and isIPv6 seems like it's one or the other.

- The clear naming convention is _initial_underscores_for_members.

- You seem to have re-indented some of the file.  Whether or not the new 
indention is better, it is very annoying to deal with in a patch that also has 
substantive changes.

I'd be willing to look at a revision.  Thanks again.
Eddie


Johan Bergs wrote:
> Hmm...
> It seems that the attachments to the mail below were not submitted
> properly...
> I hope they get sent successfully this time...
> 
> Regards,
> 
> Johan.
> 
> ---------- Forwarded message ----------
> From: Johan Bergs <johan.bergs at gmail.com>
> Date: Wed, Mar 4, 2009 at 9:21 AM
> Subject: [PATCH] IPv6 support
> To: click at pdos.csail.mit.edu
> 
> 
> Eddie,
> attached, please find two patches, both regarding IPv6 support in click.
> 
> The first fixes a bug in IP6Address, that caused the length of a 128 bit
> netmask not to be calculated correctly.
> The second adds code to FromHost (userlevel) that allows the use of either
> an IPv4 or an IPv6 address on a tun/tap device.
> 
> Regards,
> 
> Johan.
> 
> 
> 
> 
> 
> 
> --
> Johan Bergs
> PATS Research Group
> Dept. of Mathematics & Computer Science
> University of Antwerp
> Middelheimlaan 1
> 2020 Antwerpen, Belgium
> 
> Phone: +32 (0)3 265 35 19
> Fax: +32 (0)3 265 37 77
> Mail: johan.bergs at ua.ac.be
> www.pats.ua.ac.be
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click