[Click] [PATCH] Resend: radiotapdecap endianness fixes

Eddie Kohler kohler at cs.ucla.edu
Mon Mar 2 17:45:26 EST 2009


How ridiculous am I?  I completely forgot that le32_to_cpu is defined in glue.hh!

Both your fixes are applied.  Thank you very much!

Eddie


Alastair McKinley wrote:
> Hi Eddie,
> 
> How's this?
> 
> Alastair
> 
> On Mon, Feb 23, 2009 at 6:58 PM, Eddie Kohler <kohler at cs.ucla.edu> wrote:
>> Alastair,
>>
>> I'd like to include something like this, but le32_to_cpu is not a standard
>> function, it is probably only defined on Linux?.  If you could resubmit with
>> a version that checks for le32_to_cpu and maybe defines a version if it is
>> not there, that would be better.
>>
>> Eddie
>>
>>
>> Alastair McKinley wrote:
>>> Hi Eddie,
>>>
>>> Please consider this patch for Click 1.7.
>>>
>>> It is a few simple endianness fixes for RadiotapDecap as it is currently
>>> broken on big endian.
>>>
>>> Best regards,
>>>
>>> Alastair
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> click mailing list
>>> click at amsterdam.lcs.mit.edu
>>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click


More information about the click mailing list