[Click] [PATCH] Resend: radiotapdecap endianness fixes

Alastair McKinley amckinley03 at googlemail.com
Mon Feb 23 14:20:11 EST 2009


Hi Eddie,

I see that le32_to_cpu checks for apple and otherwise for <byteswap.h>.
Is there no byteswap.h on BSD?

Alastair


On Mon, Feb 23, 2009 at 6:58 PM, Eddie Kohler <kohler at cs.ucla.edu> wrote:

> Alastair,
>
> I'd like to include something like this, but le32_to_cpu is not a standard
> function, it is probably only defined on Linux?.  If you could resubmit with
> a version that checks for le32_to_cpu and maybe defines a version if it is
> not there, that would be better.
>
> Eddie
>
>
> Alastair McKinley wrote:
>
>> Hi Eddie,
>>
>> Please consider this patch for Click 1.7.
>>
>> It is a few simple endianness fixes for RadiotapDecap as it is currently
>> broken on big endian.
>>
>> Best regards,
>>
>> Alastair
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> click mailing list
>> click at amsterdam.lcs.mit.edu
>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>>
>


More information about the click mailing list