[Click] [PATCH] EtherAddress needs packing
Eddie Kohler
kohler at cs.ucla.edu
Wed Feb 18 13:20:44 EST 2009
Hi Harald,
On which machine is sizeof(EtherAddress) not 6? Just curious what problem
this is solving.
Thanks-
Eddie
Harald Schiöberg wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> class EtherAddress needs to be a CLICK_SIZE_PACKED_STRUCTURE, since
> ethernet header fields are directly cast into this class.
>
> e.g. arpquerier.cc line 242:
> EtherAddress *dst_eth = reinterpret_cast<EtherAddress*>
> (&q->ether_header()->ether_dhost);
>
> patch is attached
>
> - --
> Harald Schiöberg
> Technische Universität Berlin | T-Laboratories | FG INET
> www: http://www.net.t-labs.tu-berlin.de
> Phone: +49-(0)30-8353-58476 | Fax: +49-(0)391 534 783 47
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFJmweXy8wrZ9OvkU0RAtroAJkB2B+7lx2R9JDk0sbOOLoEPCa1EgCgv0l2
> NZLFHKHK/ETD10m+qEZtXbY=
> =dyg/
> -----END PGP SIGNATURE-----
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
More information about the click
mailing list