[Click] [PATCH] patches for linux 2.6.24
Joonwoo Park
joonwpark81 at gmail.com
Mon Sep 8 04:01:22 EDT 2008
Hi Peter,
I believe hang up problem that you are suffering was caused by recent
commit of click. (discussion on : [Click] Spinlock Problems )
Kevin and Eddie posted patch for that. I believe that those patches
would be help.
But I think this problem is different kind of problem from mount &
unmount sequence things.
Thanks,
Joonwoo
2008/9/8 Peter Dedecker <Peter.Dedecker at intec.ugent.be>
>
> Hi Kevin,
>
> I couldn't try 2.6.19.2 as this breaks FC9.
>
> For the sys hangup, I tried running click-install in gdb to find the
> line where it makes the system hang:
>
> unload_click (errh=[pointer]) at common.cc:101
> if(!f)
> FILE *f = fopen(clickfs_config.c_str(), "w");
> if(!f)
> fputs("// nothing\n", f);
> fclose(f);
>
> At the fclose(f), the system hangs.
>
> Joonwoo, is it possible this has anything to do with the unloading of
> linuxmodule before
> unmounting procklikefs?
>
> Thans a lot!
>
> Peter
>
>
>
> On Fri, Sep 5, 2008 at 5:57 PM, <springbo at cs.wisc.edu> wrote:
> > Hi Peter,
> >
> > I'm not sure it is the same issue, but I am also seeing hangups with
> > click-uninstall using 2.6.19.2 linuxmodule click with the current trunk. I
> > would be very interested to know if the current trunk works with 2.6.19.2
> > for you.
> >
> > Kevin
> >
> >
> >
> >> Hi Joonwoo,
> >>
> >> I tried 2.6.24.7. This works now, partly. The click module loads, but
> >> I suppose there are some bugs in the kernel. First time I checked,
> >> click reported the usage of eth1 while the device was down. "ifconfig
> >> eth1 up" resulted in system hangup. Reboot, "ifconfig eth1 0.0.0.0 up"
> >> worked, as well as click-install router_conf. But now click-uninstall
> >> results in a sys hangup. Strange behavior, isn't it?
> >>
> >> Thanks a lot!
> >>
> >> Peter
> >>
> >>
> >>
> >> Peter Dedecker wrote:
> >>> Hi Joonwoo,
> >>>
> >>> I retried, with the with-linux option after a make clean, but no
> >>> results. Still the Unknown symbol _ZN6VectorI7IPRouteED1Ev.
> >>>
> >>> I tried kernel 2.6.24.7 yesterday but had a few problems, I'll retry
> >>> today.
> >>>
> >>> Thanks,
> >>>
> >>> Peter
> >>>
> >>>
> >>> On Fri, Sep 5, 2008 at 8:01 AM, Joonwoo Park <joonwpark81 at gmail.com>
> >>> wrote:
> >>>> Hi Peter,
> >>>>
> >>>> Did you run configure --with-linux=/usr/src/linux ?
> >>>> Or have you tried make clean and build again?
> >>>>
> >>>> Thanks,
> >>>> Joowoo
> >>>>
> >>>> 2008/9/4 Peter Dedecker <Peter.Dedecker at intec.ugent.be>:
> >>>>> Hi Joonwoo,
> >>>>>
> >>>>> The unknown symbol is _ZN6VectorI7IPRouteED1Ev
> >>>>>
> >>>>> I configured with following command:
> >>>>> ./configure --enable-linuxmodule --disable-userlevel --enable-debug
> >>>>>
> >>>>> I'm sure I booted to the correct kernel (2.6.24-click) with
> >>>>> /urs/src/linux pointing to the 2.6.24 dir.
> >>>>>
> >>>>> I'll try 2.6.24.7 within a few hours.
> >>>>>
> >>>>> Thanks a lot!
> >>>>>
> >>>>> Peter
> >>>>>
> >>>>>
> >>>>> Joonwoo Park wrote:
> >>>>>> Hi Peter,
> >>>>>>
> >>>>>> After click-install is failed. please show me the message of 'dmesg
> >>>>>> | tail'.
> >>>>>> And can you please show me your click configure command? e.g)
> >>>>>> click/configure --with-linux=/usr/src/linux
> >>>>>> Is that pointing correct linux-2.4 directory?
> >>>>>>
> >>>>>> You can try 2.6.24.7 as well if you have change.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Joonwoo
> >>>>>>
> >>>>>> 2008/9/4 Peter Dedecker <Peter.Dedecker at intec.ugent.be>:
> >>>>>>> Hi Jonwoo,
> >>>>>>>
> >>>>>>> I only get this:
> >>>>>>>
> >>>>>>> # click-install router_configuration
> >>>>>>> insmod: error inserting '/usr/local/lib/proclikefs.ko': -1 Invalid
> >>>>>>> module
> >>>>>>> format
> >>>>>>> click-install: '/sbin/insmod /usr/local/lib/proclikefs.ko' failed
> >>>>>>>
> >>>>>>> Is there a possibility to find out which symbol it is?
> >>>>>>>
> >>>>>>> Peter
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Joonwoo Park schreef:
> >>>>>>>> Hi Peter,
> >>>>>>>>
> >>>>>>>> Can you please post which symbol it is?
> >>>>>>>>
> >>>>>>>> Joonwoo
> >>>>>>>>
> >>>>>>>> 2008/9/3 Peter Dedecker <Peter.Dedecker at intec.ugent.be>:
> >>>>>>>>> Hi all,
> >>>>>>>>>
> >>>>>>>>> After compiling and installing click with the patches and kernel
> >>>>>>>>> module
> >>>>>>>>> for kernel 2.6.24, I get an "unknown symbol in module" error at
> >>>>>>>>> the
> >>>>>>>>> insmod command. I use click-install with a very simple config
> >>>>>>>>> file that
> >>>>>>>>> worked fine before.
> >>>>>>>>>
> >>>>>>>>> Config file is the following:
> >>>>>>>>>
> >>>>>>>>> FromDevice(eth2, PROMISC 1) -> C1 :: Counter -> Q1 :: Queue(10) ->
> >>>>>>>>> BandwidthShaper(250000) -> ToDevice(eth1);
> >>>>>>>>> FromDevice(eth1, PROMISC 1) -> C2 :: Counter -> Q2 :: Queue(10) ->
> >>>>>>>>> BandwidthShaper(250000) -> ToDevice(eth2);
> >>>>>>>>>
> >>>>>>>>> Thanks a lot!
> >>>>>>>>>
> >>>>>>>>> Peter
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Peter Dedecker schreef:
> >>>>>>>>>> Hi Roman,
> >>>>>>>>>>
> >>>>>>>>>> Thanks for your quick help, this works like a charm! Thanks a
> >>>>>>>>>> lot!
> >>>>>>>>>>
> >>>>>>>>>> Peter
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Roman Chertov schreef:
> >>>>>>>>>>> Peter,
> >>>>>>>>>>> The patch will not work on a 1.6.0 release. You have to use
> >>>>>>>>>>> it on
> >>>>>>>>>>> a specific revision number
> >>>>>>>>>>> 1fcfd45c59178fbbf34be25b632164818c16a3d0.
> >>>>>>>>>>> You need to get Click via git, and then when you enter the click
> >>>>>>>>>>> directory you have to do "git checkout
> >>>>>>>>>>> 1fcfd45c59178fbbf34be25b632164818c16a3d0". After that step, you
> >>>>>>>>>>> can
> >>>>>>>>>>> use "git apply" to apply the patch.
> >>>>>>>>>>>
> >>>>>>>>>>> Roman
> >>>>>>>>>>>
> >>>>>>>>>>> Peter Dedecker wrote:
> >>>>>>>>>>>> Hi all,
> >>>>>>>>>>>>
> >>>>>>>>>>>> I'm trying to install click on Fedora Core 9. Building a
> >>>>>>>>>>>> patched
> >>>>>>>>>>>> 2.6.24 kernel was no problem, but I get a few FAILED messages
> >>>>>>>>>>>> and some
> >>>>>>>>>>>> big offsets while patching a fresh click-1.6.0 with the patches
> >>>>>>>>>>>> provided in this thread, see dump below. I tried to apply the
> >>>>>>>>>>>> failed
> >>>>>>>>>>>> patches manually, wich wasn't that hard, but after that I got
> >>>>>>>>>>>> some
> >>>>>>>>>>>> compilation errors (eg an unclosed ifndef in packet.hh) which I
> >>>>>>>>>>>> couldn't easily resolve.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Are you sure this patch applies to a fresh click-1.6.0? Thanks
> >>>>>>>>>>>> a lot.
> >>>>>>>>>>>>
> >>>>>>>>>>>> KR,
> >>>>>>>>>>>>
> >>>>>>>>>>>> Peter
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Dump:
> >>>>>>>>>>>> # patch -p1 -b < ../oneshot-click-1.6.patch
> >>>>>>>>>>>> patching file config-linuxmodule.h.in
> >>>>>>>>>>>> patching file configure
> >>>>>>>>>>>> Hunk #1 succeeded at 14415 (offset -433 lines).
> >>>>>>>>>>>> Hunk #3 succeeded at 14829 (offset -433 lines).
> >>>>>>>>>>>> patching file configure.in
> >>>>>>>>>>>> Hunk #1 succeeded at 834 (offset -24 lines).
> >>>>>>>>>>>> Hunk #3 succeeded at 926 (offset -24 lines).
> >>>>>>>>>>>> patching file drivers/e1000-7.x/src/Makefile
> >>>>>>>>>>>> patching file drivers/e1000-7.x/src/e1000_main.c
> >>>>>>>>>>>> patching file drivers/e1000-7.x/src/kcompat.h
> >>>>>>>>>>>> patching file elements/linuxmodule/anydevice.cc
> >>>>>>>>>>>> Hunk #1 succeeded at 233 (offset -65 lines).
> >>>>>>>>>>>> patching file elements/linuxmodule/fromdevice.cc
> >>>>>>>>>>>> Hunk #1 succeeded at 258 (offset 3 lines).
> >>>>>>>>>>>> patching file elements/linuxmodule/todevice.cc
> >>>>>>>>>>>> Hunk #1 succeeded at 318 (offset 13 lines).
> >>>>>>>>>>>> patching file elements/linuxmodule/tohost.cc
> >>>>>>>>>>>> Hunk #1 FAILED at 151.
> >>>>>>>>>>>> 1 out of 1 hunk FAILED -- saving rejects to file
> >>>>>>>>>>>> elements/linuxmodule/tohost.cc.rej
> >>>>>>>>>>>> patching file include/click/packet.hh
> >>>>>>>>>>>> Hunk #1 succeeded at 341 (offset -129 lines).
> >>>>>>>>>>>> Hunk #2 succeeded at 524 (offset -19 lines).
> >>>>>>>>>>>> Hunk #3 succeeded at 428 (offset -132 lines).
> >>>>>>>>>>>> Hunk #4 succeeded at 596 (offset -10 lines).
> >>>>>>>>>>>> Hunk #5 succeeded at 488 (offset -135 lines).
> >>>>>>>>>>>> Hunk #6 succeeded at 627 (offset -13 lines).
> >>>>>>>>>>>> Hunk #7 succeeded at 604 (offset -162 lines).
> >>>>>>>>>>>> Hunk #8 FAILED at 1149.
> >>>>>>>>>>>> Hunk #9 FAILED at 1169.
> >>>>>>>>>>>> Hunk #10 FAILED at 1236.
> >>>>>>>>>>>> Hunk #11 succeeded at 1178 (offset -245 lines).
> >>>>>>>>>>>> Hunk #12 FAILED at 1364.
> >>>>>>>>>>>> 4 out of 12 hunks FAILED -- saving rejects to file
> >>>>>>>>>>>> include/click/packet.hh.rej
> >>>>>>>>>>>> patching file lib/glue.cc
> >>>>>>>>>>>> Hunk #2 succeeded at 686 (offset -37 lines).
> >>>>>>>>>>>> patching file lib/ino.cc
> >>>>>>>>>>>> patching file lib/packet.cc
> >>>>>>>>>>>> Hunk #1 succeeded at 251 (offset -184 lines).
> >>>>>>>>>>>> patching file linuxmodule/Makefile.in
> >>>>>>>>>>>> Hunk #1 FAILED at 84.
> >>>>>>>>>>>> 1 out of 2 hunks FAILED -- saving rejects to file
> >>>>>>>>>>>> linuxmodule/Makefile.in.rej
> >>>>>>>>>>>> patching file linuxmodule/proclikefs.c
> >>>>>>>>>>>> patching file linuxmodule/skbmgr.cc
> >>>>>>>>>>>> _______________________________________________
> >>>>>>>>>>>> click mailing list
> >>>>>>>>>>>> click at amsterdam.lcs.mit.edu
> >>>>>>>>>>>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
> >>>>>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> ir. Peter Dedecker
> >>>>>>>>> IBCN Research Group
> >>>>>>>>> Department of Information Technology (INTEC)
> >>>>>>>>> Ghent University
> >>>>>>>>> Gaston Crommenlaan 8 bus 201, B-9050 Gent
> >>>>>>>>> Tel: +32(0)9 3314977, Fax: +32(0)9 2649969
> >>>>>>>>> Peter.Dedecker at intec.UGent.be
> >>>>>>>>> _______________________________________________
> >>>>>>>>> click mailing list
> >>>>>>>>> click at amsterdam.lcs.mit.edu
> >>>>>>>>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
> >>>>>>>>>
> >>>>>>> --
> >>>>>>> ir. Peter Dedecker
> >>>>>>> IBCN Research Group
> >>>>>>> Department of Information Technology (INTEC)
> >>>>>>> Ghent University
> >>>>>>> Gaston Crommenlaan 8 bus 201, B-9050 Gent
> >>>>>>> Tel: +32(0)9 3314977, Fax: +32(0)9 2649969
> >>>>>>> Peter.Dedecker at intec.UGent.be
> >>>>>>>
> >>>>> --
> >>>>> ir. Peter Dedecker
> >>>>> IBCN Research Group
> >>>>> Department of Information Technology (INTEC)
> >>>>> Ghent University - IBBT
> >>>>> Gaston Crommenlaan 8 bus 201, B-9050 Gent
> >>>>> Tel: +32(0)9 3314977, Fax: +32(0)9 2649969
> >>>>> Peter.Dedecker at intec.UGent.be
> >>>>>
> >>>
> >>>
> >>>
> >>
> >> --
> >> ir. Peter Dedecker
> >> IBCN Research Group
> >> Department of Information Technology (INTEC)
> >> Ghent University - IBBT
> >> Gaston Crommenlaan 8 bus 201, B-9050 Gent
> >> Tel: +32(0)9 3314977, Fax: +32(0)9 2649969
> >> Peter.Dedecker at intec.UGent.be
> >> _______________________________________________
> >> click mailing list
> >> click at amsterdam.lcs.mit.edu
> >> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
> >>
> >
> >
> >
>
>
>
> --
> Peter Dedecker
> Peter at peterdedecker.eu
> Kleine Kerkstraat 24 - 9050 Gent (Ledeberg)
> GSM: 0486/15.23.20
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
More information about the click
mailing list