[Click] FromDump generates unneeded expensive_uniqueify's

[Bart Braem]

Hi,

The following script:

FromDump("http.cap", TIMING false, ACTIVE true, STOP true)
         -> Strip(14)
         -> MarkIPHeader
         -> SetIPChecksum
         -> Discard;

Will generate an expensive_uniqueify for each packet that is pulled  
from the dump file (test it with e.g. <http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=view&target=http.cap 
 >). That does not seem a good idea.
Problem tested in Click-1.6.0 and git HEAD.
It seems as though the code in FromFile::get_packet contains an error  
but we are not sure about the meaning of all fields there.

Regards,
Bart and Peter
-- 
PATS research group - IBBT
Dept. of Mathematics and Computer Sciences
University of Antwerp
Campus Middelheim, G3.30
Middelheimlaan 1
B-2020 Antwerpen, Belgium
Phone: +32 (0)3 265.32.91
Fax: +32 (0)3 265.37.77
Web: www.pats.ua.ac.be