[Click] [PATCH] PaintTee: configure parsing bug

Eddie Kohler kohler at cs.ucla.edu
Sun Nov 23 02:10:47 EST 2008


Wow, thanks very much!  That sure is a bug.  Your fix is applied.

Eddie


Barret Rhoden wrote:
> Hi - 
> 
> This fixes a config error in PaintTee.  It was crashing click with a
> variety of memory errors while running on 2.6.24.
> 
> Barret
> 
> 
> ---
>  elements/standard/painttee.cc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/elements/standard/painttee.cc
> b/elements/standard/painttee.cc index e5d8b28..a65afd3 100644
> --- a/elements/standard/painttee.cc
> +++ b/elements/standard/painttee.cc
> @@ -36,7 +36,7 @@ PaintTee::configure(Vector<String> &conf,
> ErrorHandler *errh) {
>      int anno = PAINT_ANNO_OFFSET;
>      if (cp_va_kparse(conf, this, errh,
> -		     "COLOR", cpkP+cpkM, cpUnsigned, &_color,
> +		     "COLOR", cpkP+cpkM, cpByte, &_color,
>  		     "ANNO", cpkP, cpAnno, 1, &anno,
>  		     cpEnd) < 0)
>  	return -1;


More information about the click mailing list