[Click] [PATCH] patches for linux 2.6.24

[Joonwoo Park]

2008/2/14, Joonwoo Park <joonwpark81 at gmail.com>:
> On Mon, Feb 11, 2008 at 05:10:18PM -0000, Egi, Norbert wrote:
> > >I guess the assertion issue  is releated locking problem, I sent a patch for it.
> > >Since I'm off for this week, I can't test your patch at this moment.
> > >I'll dig these things at next week and I'll try NAPI as a possible
> > >option for e1000 that you patched.
> >
> > Joonwoo,
> >
> > Yes, it was related to a locking problem when I wanted to have the interfaces in promiscuous mode. It looks so that the dev_set_promiscuity function (in net/core/dev.c) requires the calling thread to hold rtnl mutex by calling rtnl_lock(), so I added this to anydevice.cc with the corresponding rtnl_unlock(). This eliminated the assertion problem I had. So far I haven't experienced any other problems with the patches yet. (By the way, I didn't get the patch you mentioned above.)
> >
> > Cheers,
> > Norbert
>
> Hi Norbert,
> I think you made a indentation mistake.
> After fixing it, the RTNL_LOCK assertion was disappeared.
> I'm attaching a mergered patch as click-1.6.0-linux-2.6.24-3.patch.gz as
> well.
>
> ---

Hi forks,
I've updated draft patch for linux 2.6.24.
- fix spinlock init macro
- re-enable skb_recycle
- fix enormous memory leak in skb_recycle

Eddie,
I guess, also the version of 2.6.19's skb_recycle needs
skb_release_data for fix potential memory leakage.
Please consider it.

Thanks,
Joonwoo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: click-1.6.0-linux-2.6.24-4.patch.gz
Type: application/x-gzip
Size: 70528 bytes
Desc: not available
Url : https://pdos.csail.mit.edu/pipermail/click/attachments/20080320/ac7e3a42/attachment-0001.bin