[Click] FromDump generates unneeded expensive_uniqueify's

[Bart Braem]

Hi Eddie,

On 01 Dec 2008, at 17:41, Eddie Kohler wrote:

> This is not actually a problem or error.  The deal here is this.   
> FromDump, via FromFile, reads dump data from a memory mapped file  
> (when it can).  The file is mapped read-only.  FromFile then emits  
> packets that are partial clones of the memory mapped buffer.  This  
> makes efficient use of the file, especially when packets from the  
> dump aren't modified.  However, if a packet *is* modified, it must  
> be uniqueified, since it is a partial clone of a buffer containing  
> more than just the one packet.  This uniqueification shouldn't be  
> more expensive than creating a fresh packet in the first place.


Thanks for this explanation. I must say that this is a very  
intelligent way of working with dumps. I fully agree that this is not  
a problem or an error.

Regards,
Bart
-- 
Bart Braem
PATS research group - IBBT
Dept. of Mathematics and Computer Sciences
University of Antwerp
Campus Middelheim, G3.30
Middelheimlaan 1
B-2020 Antwerpen, Belgium
Phone: +32 (0)3 265.32.91
Fax: +32 (0)3 265.37.77
Web: www.pats.ua.ac.be