[Click] Tiny fix for etc/pkg-userlevel.mk
Pavlos Papageorgiou
pavlos at cs.umd.edu
Mon Sep 17 17:10:08 EDT 2007
Hi Eddie,
I suggest the following fix in click/etc/pkg-userlevel.mk.
My build fails when:
- I build a package (click already built successfully)
and
- I override CXX when I invoke the package makefile
(I build userlevel and linuxmodule in one shot)
In pkg-userlevel the -fPIC flag is appended to CXX instead
of CXXFLAGS and as a result disappears when someone overrides
CXX. Adding -fPIC to the overridden CXX does not work either,
because pkg-linuxmodule.mk uses the same CXX variable and
tries to use -fPIC for the kernel, where of course it fails.
Thanks,
Pavlos
diff -ur a/click/etc/pkg-userlevel.mk b/click/etc/pkg-userlevel.mk
--- a/click/etc/pkg-userlevel.mk 2007-09-17 16:51:00.404902000 -0400
+++ b/click/etc/pkg-userlevel.mk 2007-09-17 16:52:37.245244000 -0400
@@ -15,9 +15,9 @@
CLICKBUILD = userlevel
-CC ?= $(CLICKCC) -fPIC
+CC ?= $(CLICKCC)
CPP ?= $(CLICKCPP)
-CXX ?= $(CLICKCXX) -fPIC
+CXX ?= $(CLICKCXX)
CXXCPP ?= $(CLICKCXXCPP)
AR_CREATE ?= $(CLICKAR_CREATE)
RANLIB ?= $(CLICKRANLIB)
@@ -28,6 +28,9 @@
CXXFLAGS ?= $(CLICKCXXFLAGS)
DEPCFLAGS ?= $(CLICKDEPCFLAGS)
+CFLAGS += -fPIC
+CXXFLAGS += -fPIC
+
DEFS ?= $(CLICKDEFS)
INCLUDES ?= $(CLICKINCLUDES)
LDFLAGS ?= $(CLICKLDMODULEFLAGS)
More information about the click
mailing list