[Click] HostEtherFilter and Multicast

Eddie Kohler kohler at cs.ucla.edu
Mon May 21 11:55:29 EDT 2007


Ouch!!  An embarrassing error!  It is now fixed, thank you.

Eddie


Pierre-Emmanuel Le Roux wrote:
> Hi all,
> 
> I think there is a problem with the HostEtherFilter module and multicast 
> address handling.
> 
> An ethernet address is multicast if the bit 0 of the first byte is set to '1'. 
> So the test done by HostEtherFilter should be:
> ...
> } else if (e->ether_dhost[0] & 0x01) {
>   p->set_packet_type_anno(Packet::MULTICAST);
>   return p;
> }
> ... 
> instead of:
> ...
> } else if (e->ether_dhost[0] & 0x80) {
>   p->set_packet_type_anno(Packet::MULTICAST);
>   return p;
> }
> ...
> 
> Regards.


More information about the click mailing list