[Click] Problem Using click-mkmindriver - Fixed

[Jason Park (Joonwoo Park)]

Eddie,

Thanks for applying the patch.
I agree that it is hard to say the elements depend on IPNameInfo.
Therefore, I think so it would be better includes the elements by
mk-mindriver.

Jason Park (Joonwoo Park)

-----Original Message-----
From: Eddie Kohler [mailto:kohler at cs.ucla.edu] 
Sent: Sunday, June 17, 2007 5:50 AM
To: Jason Park (Joonwoo Park)
Cc: click at amsterdam.lcs.mit.edu
Subject: Re: [Click] Problem Using click-mkmindriver - Fixed

Jason,

Thanks very much for this fix.  I've checked in the patch to the linuxmodule

Makefile.  As for this one, it's a bit stranger.  I checked in a fix to 
IPFilter so that a bad configuration string won't cause a crash.  But, see, 
the IPClassifier and IPFilter elements don't strictly speaking DEPEND on 
IPNameInfo.  You can give IPClassifier/IPFilter numeric port specifications.

My tendency at this point would be to change click-mkmindriver so that by 
default it includes IPNameInfo and Align, generally useful elements.  A new 
option will say "leave those out".  What do you think?

E


Jason Park (Joonwoo Park) wrote:
> Hi.
> It is seems to IPFilter element requires IPNameInfo.
> A patch file attached and it works for me.
> 
> Jason Park (Joonwoo Park)
> 
> -----Original Message-----
> From: click-bounces at pdos.csail.mit.edu
> [mailto:click-bounces at pdos.csail.mit.edu] On Behalf Of Jason Park (Joonwoo
> Park)
> Sent: Friday, June 08, 2007 4:00 PM
> To: kohler at cs.ucla.edu
> Cc: click at pdos.csail.mit.edu
> Subject: [Click] Problem Using click-mkmindriver
> 
> Hi.
> 
> Recently I updated the click with version 1.6pre, but I encountered a
> problem with 'click-mkmindriver'.
> I just wrote a simple click config 'ipclassifier.click' which works nicely
> with click.ko (built with 'make linuxmodule').
> But the config 'ipclassifier.click' does not work with package which built
> linxumodule from 'click-mkmindriver' (built with 'make linuxmodule
> MINDRIVEER=jason').
> I got panic, after installing same config.
> No other guys have problem with 'click-mkmindriver'?
> Here I'm attaching message of kernel oops, ipclassifier.click and
> click-mkmindriver commands.
> It is latest CVS click on linux 2.6.19.2 SMP.
> 
> Thanks in advance.
> 
> Jason Park (Joonwoo Park)