[Click] the errors in click-DSR

[Eddie Kohler]

Hi Dries;

Looking at the DSR internet-draft, it looks like your idea makes sense, and I 
am going to check in that change.  However, several other places in the code 
have similar issues, and I am not changing them for now.

Eddie


Dries Naudts wrote:
> Hi all,
> 
> I agree on the first item , but I would change line 991 (index 
> modification) to
> 
> p->set_dst_ip_anno(source_route[source_route.size() - 2].addr());
> 
> 
> Best routes are calculated with the linktable element with 'from_me' 
> parameter set to false, so in source_route:
> [0] -> last hop
> [1] -> previous last hop
> [..]
> [n-1] -> next hop
> [n] -> source hop
> 
> So if you want to direct the next hop, you need index 
> [source_route.size() - 2]
> 
> Can anyone verify this?
> 
> Regards,
> Dries
> 
> 
> 
> 
> Eddie Kohler wrote:
>> Hi,
>>
>> Thanks very much for this fix.  I'm going to apply it to
>> make-dsr-config.pl and to
>> elements/grid/dsrroutetable.cc.
>> Anyone who knows more about these elements feel free to say this is a
>> bad idea.
>>
>> I WISH THERE WEREN'T SO MANY VERSIONS OF OLD BROKEN ROOFNET CONFIGS
>> AND ELEMENTS IN THE CLICK SOURCE.  IF ONLY SOMEONE WOULD TELL ME WHICH
>> ONES TO ARCHIVE.  HINT, HINTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTT
>>
>> Eddie
>>
>>
>>  
>>> In fact I faced the exactly the same questions like
>>> you about almost one year before.
>>> DSDV is OK ,but DSR  DSRArpTable ::push missing ...
>>>  I and my mate have managed to find out the errors
>>> though it took us many many days...  :(
>>> Now,I advice you to fix two places :
>>> 1 in dsr.click configuration  ,look for :
>>>   kt::kernulTun()-> strip(14)->...
>>>   delete "strip(14)"  here !
>>> 2. in dsrroutetable.cc ,look for sub_funciton
>>> add_dsr_header(), in the almost last few lines ,change
>>> the last index you find "1" to "0" ([1]->[0])
>>>
>>> After correct them ,run "gmake" in /click ,to
>>> recomplie.
>>>
>>> I am in windows ,so I can not tell you the exactly
>>> place or paste the source code here .I hope you will
>>> find the 2 places.
>>> Do hope it will help you !   :) 
>>>     
>> _______________________________________________
>> click mailing list
>> click at amsterdam.lcs.mit.edu
>> https://amsterdam.lcs.mit.edu/mailman/listinfo/click
>>   
> 
>