[Click] dhcp cookie

Nick ntg at cs.umd.edu
Sun Apr 29 16:53:45 EDT 2007


Hi,

I think in package dhcp, in
DHCPClient::make_discovery
it should be
  memcpy(&(discover_msg->magic), DHCP_OPTIONS_COOKIE, 4);
  option_ptr = discover_msg->options;
instead of
  memcpy(discover_msg->options, DHCP_OPTIONS_COOKIE, 4);
  option_ptr = discover_msg->options + 4;

and in DHCPClient::make_release
  memcpy((unsigned char*)&(release_msg->magic), DHCP_OPTIONS_COOKIE, 4);
  option_ptr = release_msg->options;
instead of
  memcpy(release_msg->options, DHCP_OPTIONS_COOKIE, 4);
  option_ptr = release_msg->options + 4;

otherwise I think the packages are not created correctly and seem to be 
dropped.

Nick
PS. Hopefully this is the correct place to send this... If not excuse 
me. Btw click is cool!


More information about the click mailing list