[Click] nsclick writehandler patch

Eddie Kohler kohler at cs.ucla.edu
Fri Jan 20 17:02:57 EST 2006


Hi Bart,

I applied a different version of this patch that uses a more standard way of 
reporting handler errors.  Please let me know if behavior has changed 
inappropriately.

Eddie


Bart Braem wrote:
> At the bottom of  ns/nsclick.cc writehandlers are called. However, if those 
> handlers or those elements do not exist nothing happens. It would be nice to 
> generate a warning, similar to the approach of readhandlers:
>     if (Element* e = r->find(elementname)) {
> 	if (const Handler* h = r->handler(e, handlername))
> 	    if (h->write_visible())
> 		return h->call_write(writestring, e, ErrorHandler::default_handler());
> 	click_chatter("writehandler: no such handler '%s'", handlername);
> 	return -2;
>     } else
> 	click_chatter("writehandler: no such element '%s'",elementname);
> 	return -1;
> 
> Bart
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click


More information about the click mailing list