[Click] x86_64 compilation fixes

Eddie Kohler kohler at cs.ucla.edu
Thu Feb 2 15:28:41 EST 2006


Thanks!  Thought I got all these a while ago...  Checked in.

Eddie


On Feb 2, 2006, at 11:51 AM, Mark Huang wrote:

> Fixes various pointer-to-integer-cast fatal warnings. Pointers are
> 8 bytes on x86_64.
> Patch: Fix various pointer-to-integer-cast fatal warnings. Pointers  
> are
> 8 bytes on x86_64.
> Signed-off-by: Mark Huang <mlhuang at cs.princeton.edu>
>
> Index: elements/aqm/red.cc
> ===================================================================
> RCS file: /home/am0/click/cvsroot/release/one/elements/aqm/red.cc,v
> retrieving revision 1.50
> diff -u -r1.50 red.cc
> --- elements/aqm/red.cc	9 Jan 2006 19:03:35 -0000	1.50
> +++ elements/aqm/red.cc	2 Feb 2006 19:48:46 -0000
> @@ -322,7 +322,7 @@
>  RED::read_parameter(Element *f, void *vparam)
>  {
>      RED *red = (RED *)f;
> -    switch ((int)vparam) {
> +    switch ((intptr_t)vparam) {
>        case 0:			// min_thresh
>  	return String(red->_min_thresh);
>        case 1:			// max_thresh
> Index: elements/standard/pokehandlers.cc
> ===================================================================
> RCS file: /home/am0/click/cvsroot/release/one/elements/standard/ 
> pokehandlers.cc,v
> retrieving revision 1.39
> diff -u -r1.39 pokehandlers.cc
> --- elements/standard/pokehandlers.cc	9 Jan 2006 19:03:44 -0000	1.39
> +++ elements/standard/pokehandlers.cc	2 Feb 2006 19:48:47 -0000
> @@ -147,7 +147,7 @@
>  {
>      PokeHandlers *p = (PokeHandlers *)e;
>      String s = cp_uncomment(in_s);
> -    switch ((int) v) {
> +    switch ((intptr_t) v) {
>      case 0:
>  	p->unpause();
>  	break;
> Index: elements/standard/randomerror.cc
> ===================================================================
> RCS file: /home/am0/click/cvsroot/release/one/elements/standard/ 
> randomerror.cc,v
> retrieving revision 1.29
> diff -u -r1.29 randomerror.cc
> --- elements/standard/randomerror.cc	9 Jan 2006 19:03:44 -0000	1.29
> +++ elements/standard/randomerror.cc	2 Feb 2006 19:48:47 -0000
> @@ -181,7 +181,7 @@
>  static String
>  random_bit_errors_read(Element *f, void *vwhich)
>  {
> -  int which = (int)vwhich;
> +  int which = (intptr_t)vwhich;
>    RandomBitErrors *lossage = (RandomBitErrors *)f;
>    if (which == 0)
>      return cp_unparse_real2(lossage->p_bit_error(), 16);
> Index: elements/standard/ratedsource.cc
> ===================================================================
> RCS file: /home/am0/click/cvsroot/release/one/elements/standard/ 
> ratedsource.cc,v
> retrieving revision 1.55
> diff -u -r1.55 ratedsource.cc
> --- elements/standard/ratedsource.cc	9 Jan 2006 19:03:45 -0000	1.55
> +++ elements/standard/ratedsource.cc	2 Feb 2006 19:48:47 -0000
> @@ -162,7 +162,7 @@
>  RatedSource::read_param(Element *e, void *vparam)
>  {
>    RatedSource *rs = (RatedSource *)e;
> -  switch ((int)vparam) {
> +  switch ((intptr_t)vparam) {
>     case 0:			// data
>      return rs->_data;
>     case 1:			// rate
> @@ -186,7 +186,7 @@
>  {
>    RatedSource *rs = (RatedSource *)e;
>    String s = cp_uncomment(in_s);
> -  switch ((int)vparam) {
> +  switch ((intptr_t)vparam) {
>
>    case 0:			// data
>        rs->_data = in_s;
> Index: elements/standard/timedsource.cc
> ===================================================================
> RCS file: /home/am0/click/cvsroot/release/one/elements/standard/ 
> timedsource.cc,v
> retrieving revision 1.37
> diff -u -r1.37 timedsource.cc
> --- elements/standard/timedsource.cc	9 Jan 2006 19:03:45 -0000	1.37
> +++ elements/standard/timedsource.cc	2 Feb 2006 19:48:47 -0000
> @@ -100,7 +100,7 @@
>  TimedSource::read_param(Element *e, void *vparam)
>  {
>    TimedSource *ts = (TimedSource *)e;
> -  switch ((int)vparam) {
> +  switch ((intptr_t)vparam) {
>     case 0:			// data
>      return ts->_data;
>     case 1:			// limit
> @@ -122,7 +122,7 @@
>  {
>    TimedSource *ts = (TimedSource *)e;
>    String s = cp_uncomment(in_s);
> -  switch ((int)vparam) {
> +  switch ((intptr_t)vparam) {
>
>    case 0:			// data
>        ts->_data = in_s;
> Index: elements/userlevel/todevice.cc
> ===================================================================
> RCS file: /home/am0/click/cvsroot/release/one/elements/userlevel/ 
> todevice.cc,v
> retrieving revision 1.56
> diff -u -r1.56 todevice.cc
> --- elements/userlevel/todevice.cc	9 Jan 2006 19:03:47 -0000	1.56
> +++ elements/userlevel/todevice.cc	2 Feb 2006 19:48:47 -0000
> @@ -286,7 +286,7 @@
>  {
>    ToDevice *td = (ToDevice *)e;
>    String s = cp_uncomment(in_s);
> -  switch((int)vparam) {
> +  switch((intptr_t)vparam) {
>    case H_DEBUG: {
>      bool debug;
>      if (!cp_bool(s, &debug))
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click



More information about the click mailing list