[Click] ICMPRewriter and ICMPPingRewriter don't update destination IP address annotation

[Eddie Kohler]

Hi Arvid,

Indeed, it is an oversight that ICMPRewriter didn't have that functionality, 
and now it does.  Thanks for suggesting it.  But ICMPPingRewriter *did* 
already have that functionality, as of June 21 -- just FYI.

Eddie


Arvid Nilsson wrote:
> Hello there!
> 
> IPRewriter and TCPRewriter update the destination IP address annotation for
> packets passing through (unless you specify otherwise with the DST_ANNO
> keyword).
> 
> I was surprised that ICMPRewriter and ICMPPingRewriter don't use the same
> principle. Wouldn't it be nice if all rewriters worked the same way, by
> making them update the dest anno by default and introducing a DST_ANNO
> keyword to these elements as well?
> 
> Yours sincerely,
> 
> Arvid Nilsson
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click