[Click] CPUQueue bug and fix

[Eddie Kohler]

Hi Beyers,

Thanks for this patch!!

Eddie


Beyers Cronje wrote:
> Hi,
> 
> I'm running a simple etherswitch config :
> 
> sw :: EtherSwitch;
> out0 :: CPUQueue -> ToDevice(eth0);
> out1 :: CPUQueue -> ToDevice(eth1);
> PollDevice(eth0, PROMISC true) -> [0]sw;
> PollDevice(eth1, PROMISC true) -> [1]sw;
> sw[0] -> out0; 
> sw[1] -> out1;
> 
> I've compiled Click with mutliuthreading enabled and using
> click-install with the -t option.
> (The EtherSwitch element is the standard etherswitch element with
> added locking for MT)
> 
> I get a NULL pointer dereference as soon as the CPUQueue's pull
> function is called when all cpu queues are empty.
> 
> Adding a "return 0" at the end of pull - execution to this point
> implies empty queues - seems to fix the problem.
> 
> Regards
> 
> Beyers
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click