[Click] ToDevice stats problem

Nikitas Liogkas nikitas at CS.UCLA.EDU
Sun Feb 27 23:24:37 EST 2005


It seems to me that some of the ToDevice stats are wrong! Specifically 
_npackets now holds the number of packets pulled from the upstream queue, 
and _pulls is incremented _before_ pull() is called, so it is incremented 
even on an unsuccessful pull!

Here is a patch that makes more sense to me: _npackets now holds the number 
of sent packets, and _pulls the number of pulled packets. Given that 
_rejected holds the number of rejected packets, it is now true that _pulls = 
_npackets + _rejected.

nikitas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: todevice-stats.patch
Type: text/x-patch
Size: 961 bytes
Desc: not available
Url : https://amsterdam.lcs.mit.edu/pipermail/click/attachments/20050227/7e5af36b/todevice-stats.bin


More information about the click mailing list