[Click] _tv_sec in gaprate.hh

Eddie Kohler kohler at CS.UCLA.EDU
Mon Apr 4 10:22:18 EDT 2005


Sure, it should be a long.  This will only matter on 64-bit architectures after 
2038, but it should be a long.

E


Alan Tang wrote:
> Hi everyone,
> 
> Should  _tv_sec in gaprate.hh be type long instead of int?
> Because from http://linux.about.com/library/cmd/blcmdl2_settimeofday.htm
> 
> struct timeval {
> long    tv_sec;         /* seconds */
> long    tv_usec;        /* microseconds */
> };
> 
> and in GapRate::need_update we have if (_tv_sec < 0) {
>    _tv_sec = now.tv_sec;
> 
> So we are assigning a long to an int.
> 
> Regards
> Alan
> _______________________________________________
> click mailing list
> click at amsterdam.lcs.mit.edu
> https://amsterdam.lcs.mit.edu/mailman/listinfo/click


More information about the click mailing list