[Click] linuxmodule Packet::make fix

John Bicket jbicket at amsterdam.lcs.mit.edu
Thu Dec 2 15:08:53 EST 2004


I just checked in a fix for a bug that showed up when using FromHost in
the kernel.   If you've ever seen those messages that say "wmem_alloc !=
0", it was caused by Packet::make not calling the sk_buff destructor
(ie skb_orphan).

As a result, the packet would get recycled in click, and then the socket
would not be able to keep track of the oustanding sk_buff's it allocated
that are still somewhere in the kernel.

--john


----- Forwarded message from John Bicket <jbicket at amsterdam.lcs.mit.edu> -----

Subject: [Click-commits] release/one/include/click
From: John Bicket <jbicket at amsterdam.lcs.mit.edu>
To: click-commits at amsterdam.lcs.mit.edu
Date: Thu, 2 Dec 2004 15:03:13 -0500 (EST)

Update of /home/am0/click/cvsroot/release/one/include/click
In directory amsterdam.lcs.mit.edu:/tmp/cvs-serv84807

Modified Files:
	packet.hh 
Log Message:
orphan packets when we get them from linux; this ensures that sockets can 
do their bookkeeping correctly.


_______________________________________________
Click-commits mailing list
Click-commits at amsterdam.lcs.mit.edu
https://amsterdam.lcs.mit.edu/mailman/listinfo/click-commits

----- End forwarded message -----


More information about the click mailing list