Click extension for VLAN support

Brecht Vermeulen Brecht.Vermeulen at rug.ac.be
Wed Mar 26 15:35:36 EST 2003


Hi Eddie,

thanks for the input, so

CLICK_SIZE_PACKED_STRUCTURE(
struct click_vlan_ether {,
    uint8_t     ether_dhost[6];
    uint8_t     ether_shost[6];
    uint16_t    ether_vlan_proto;
    uint16_t    ether_vlan_tci;
    uint16_t    ether_vlan_encap_proto;
});

should do the trick.

regards,
Brecht

On Tue, 25 Mar 2003, Eddie Kohler wrote:

> Hi Brecht!
>
> > Any comments/suggestions are welcome. (an existing implementation is
> > even better :-) )
>
> I think your vlan-extended Ethernet structure looks mostly fine, except:
>
> - keep all prefixes the same (ether_vlan_proto or ether_v_proto, not
>   vlan_proto)
> - all lower case (ether_vlan_tci, not ..._vlan_TCI)
> - prefer 'ether_vlan_encap_proto' to '..._encapsulated_proto'
>
> Eddie
>




More information about the click mailing list