click and todevice packet lengths

John Bicket jbicket at mit.edu
Sat Jun 28 01:20:36 EDT 2003


Unfortunately, I had /proc/sys/whatever/panic set so I didn't see the oops,
just caught it rebooting.  

I'll definetly look more into this, I just wanted to test it out and see
if the quick fix did it.  I'm trying to finish up some loose ends before
I go to London for a week, but I will get to the bottom of this once I get 
back. 

--john


Eddie Kohler [kohler at icir.org] wrote:
>Bummer.
>
>Do you remember what the first panic was?
>
>> -    /*
>> -     * Ensure minimum ethernet packet size (14 hdr + 46 data).
>> -     * I can't figure out where Linux does this, so I don't
>> -     * know the correct procedure.
>> -     */
>> -    if (skb1->len < 60) {
>> -      if (skb_tailroom(skb1) < 60 - skb1->len) {
>> -          printk("ToDevice: too small: len %d tailroom %d\n",
>> -                 skb1->len, skb_tailroom(skb1));
>> -          kfree_skb(skb1);
>> -          return -1;
>> -      }
>> -      skb_put(skb1, 60 - skb1->len);
>> -    }
>
>Eddie



More information about the click mailing list