std C/C++ patch #8

David Scott Page page at cs.utexas.edu
Fri Apr 26 12:54:40 EDT 2002


Hi,

In lib/router.cc there are some private methods defined "extern
inline".  I suppose that the intention is to somehow instantiate the
method both inline and for export (external linkage). Since the
methods are private, presumably all uses will be in router.cc, and
hence there is no need for external linkage. This patch removes the
(non standard usage of the) extern storage-class specifier.

--
Scott Page

----------------------------- 8< --------------------------------
diff -Naur click-stdC++.7/lib/router.cc click-stdC++.8/lib/router.cc
--- click-stdC++.7/lib/router.cc	Wed Apr 24 16:39:22 2002
+++ click-stdC++.8/lib/router.cc	Fri Apr 26 16:44:27 2002
@@ -400,37 +400,37 @@
   }
 }
 
-extern inline int
+inline int
 Router::input_pidx(const Hookup &h) const
 {
   return _input_pidx[h.idx] + h.port;
 }
 
-extern inline int
+inline int
 Router::input_pidx_element(int pidx) const
 {
   return _input_eidx[pidx];
 }
 
-extern inline int
+inline int
 Router::input_pidx_port(int pidx) const
 {
   return pidx - _input_pidx[_input_eidx[pidx]];
 }
 
-extern inline int
+inline int
 Router::output_pidx(const Hookup &h) const
 {
   return _output_pidx[h.idx] + h.port;
 }
 
-extern inline int
+inline int
 Router::output_pidx_element(int pidx) const
 {
   return _output_eidx[pidx];
 }
 
-extern inline int
+inline int
 Router::output_pidx_port(int pidx) const
 {
   return pidx - _output_pidx[_output_eidx[pidx]];



More information about the click mailing list