Known hotconfig problems?

Eddie Kohler kohler at aciri.org
Tue Apr 3 13:06:19 EDT 2001


Actually, could you try this code in hotswap_config just for kicks?

.....
  if (!r)
    return -EINVAL;
  
  /* prevent interrupts */
  // changed because kevin_mitchell at agilent.com experienced crashes
  unsigned cli_flags;
  save_flags(cli_flags);
  cli();

  if (kernel_errh->nerrors() == before_errors
      && r->initialize(kernel_errh) >= 0) {
    // perform hotswap
    if (current_router && current_router->initialized())
      r->take_state(current_router, kernel_errh);
    restore_flags(cli_flags);	    // allow interrupts
    // install
    kill_current_router();
    install_current_router(r);
    set_current_config(s);
  } else {
    restore_flags(cli_flags);	// allow interrupts
    delete r;
  }
  
  return 0;

l,d




More information about the click mailing list